Ask is moving to Stack Overflow and Serverfault.com! Please use the "opendaylight" tag on either of these sites. This site is now in Read-Only mode

chenguohai's profile - activity

2015-05-12 17:53:37 -0700 commented answer there should be some improvement about the auto generated codes from YANGTOOLs

i have submitted

2015-05-07 00:02:47 -0700 received badge  Famous Question (source)
2015-05-06 18:04:32 -0700 received badge  Editor (source)
2015-05-06 18:03:04 -0700 commented answer there should be some improvement about the auto generated codes from YANGTOOLs

ok, i'll do that.

2015-05-06 14:51:07 -0700 received badge  Notable Question (source)
2015-05-06 09:40:41 -0700 received badge  Popular Question (source)
2015-05-06 01:48:08 -0700 asked a question there should be some improvement about the auto generated codes from YANGTOOLs

Hi folks,

I am reading the code under ALTO@ODL. And here are my two comments.

1:File named ‘AltoProviderImplBuilder’under alto-provider/……./modules/module/configuration :in function named 'toString',first is defined to judge a common should be inserted, i recommend writting as following

    @Override
    public java.lang.String toString() {
        java.lang.StringBuilder builder = new java.lang.StringBuilder ("AltoProviderImpl [");
        //boolean first = true;

        if (_dataBroker != null) {
            //if (first) {
            //    first = false;
            //} else {
            //    builder.append(", ");
            //}
            builder.append("_dataBroker=");
            builder.append(_dataBroker); 
            builder.append(", ");//new added

         }
        if (_rpcRegistry != null) {
            //if (first) {
            //    first = false;
            //} else {
            //    builder.append(", ");
            //}
            builder.append("_rpcRegistry=");
            builder.append(_rpcRegistry); 
            builder.append(", ");//new added

         }
        //if (first) {
        //    first = false;
        //} else {
        //    builder.append(", ");
        //}
        builder.append("augmentation=");
        builder.append(augmentation.values());
        return builder.append(']').toString();
    }
}

Fewer judgement, fewer jumpes and simplified, consistent code,Make sense. There are similar something in file named RpcRegistryBuilder.java under alto-provider/……../modules/module/configuration/alto/provider/impl

BTW,could anyone tell me who is responsible for the improvements

THANKS