Ask Your Question
0

Should I add code reviewers myself?

asked 2015-09-29 21:22:50 -0700

Sania gravatar image

updated 2015-09-29 21:24:27 -0700

Hi,
I've been working on one of openflowplugin bugs and have implemented a fix so naturally next step would be to submit code for review. I went through https://wiki.opendaylight.org/view/GettingStarted:Pulling , Hacking,andPushingAlltheCodefromthe_CLI which gives a step-by-step guide for submitting the changes. However, I'm a little confused regarding the code reviewers, do I have to add reviewers myself or is it taken care of automatically?

edit retag flag offensive close merge delete

1 answer

Sort by ยป oldest newest most voted
1

answered 2015-09-29 21:41:16 -0700

jamoluhrsen gravatar image

Sania,

You can add reviewers yourself to help expedite the process, but I am sure the committers and PTL of the project will eventually see the patch and try to assign the appropriate reviewers. For openflowplugin, at this point in time, I think you can add these three for starters:

abhijit.kumbhare @ ericsson.com

vishnoianil @ gmail.com

mirehak @ cisco.com

Also, if anyone listed on your bug is an active community member in openflowplugin, you can add them as well.

edit flag offensive delete publish link more

Comments

I just pushed the code but the jenkins build is failing. Latest openflowplugin (unmodified) fails to build (without -DskipTests) on my local machine too. Is there any work around this situation?

Sania ( 2015-10-02 21:31:10 -0700 )edit

You should check at Jenkins why and where it is failing ? Is it because or test case fail or because of your code modification ?

faizan ( 2015-10-04 04:49:51 -0700 )edit

I did and have fixed it already but thanks for your response!

Sania ( 2015-10-04 05:17:50 -0700 )edit
Login/Signup to Answer

Question Tools

Follow
1 follower

Stats

Asked: 2015-09-29 21:22:50 -0700

Seen: 65 times

Last updated: Sep 29 '15